From: Andreas Unterkircher <unki@netshadow.at>
Date: Sun, 25 May 2008 07:46:49 +0000 (+0200)
Subject: added some comments to image-preloading code
X-Git-Url: https://git.nubati.net/cgi-bin/gitweb.cgi?p=phpfspot.git;a=commitdiff_plain;h=57a136513d1e5ef86acf49b934ea3e6eff26dbfd;ds=sidebyside

added some comments to image-preloading code

Signed-off-by: Andreas Unterkircher <unki@netshadow.at>
---

diff --git a/phpfspot.js b/phpfspot.js
index ebe1242..75d0ed7 100644
--- a/phpfspot.js
+++ b/phpfspot.js
@@ -660,17 +660,19 @@ function preloadPhotos(image_url) {
    var waiting = 100;
    var counting;
 
-   lbImg=WSR_getElementsByClassName(document,"img","thumb");
-   for(i=0;i<lbImg.length;i++){
-      lbImg[i].src=image_url[i];
-      // to not bomb the server with requests, give the page some time
-      // to load the images one by one. if a image exceeds the timeout,
-      // the next image will be loaded.
-      if(lbImg[i].complete != undefined && lbImg[i].complete != true) {
-         counting = 0;
-         while(lbImg[i].complete != true && counting < timeout) {
-            window.setTimeout("noop()", waiting);
-            counting+=waiting;
+   lbImg = WSR_getElementsByClassName(document,"img","thumb");
+   if(lbImg != undefined) {
+      for(i=0;i<lbImg.length;i++){
+         lbImg[i].src=image_url[i];
+         // to not bomb the server with requests, give the page some time
+         // to load the images one by one. if a image exceeds the timeout,
+         // the next image will be loaded.
+         if(lbImg[i].complete != undefined && lbImg[i].complete != true) {
+            counting = 0;
+            while(lbImg[i].complete != true && counting < timeout) {
+               window.setTimeout("noop()", waiting);
+               counting+=waiting;
+            }
          }
       }
    }
diff --git a/themes/default/templates/photo_index.tpl b/themes/default/templates/photo_index.tpl
index 7fe04ab..fa63b31 100644
--- a/themes/default/templates/photo_index.tpl
+++ b/themes/default/templates/photo_index.tpl
@@ -135,7 +135,13 @@
 <br class="cb" />
 <script type="text/javascript" language="JavaScript">
 <!--
-   /*** image preloading ***/
+   // image preloading
+   //
+   // these few javascript lines will try to speed up loading all the photo
+   // thumbnails. An array of all photos to display will be built written
+   // by the smarty-template. The js-code will then loop through this array
+   // and invoke loading of each photo. Sadly this does not work good on all
+   // browsers.
    { counter start=-1 }
 
    var current;