avoid notice messages about undefined variables, resolves #179
[phpfspot.git] / phpfspot.class.php
index edfed95e1cae4294c6305f3f460a4f162f5eff37..1423f988f5c63ec2fa7b98aa0ad9155be776c64e 100644 (file)
@@ -213,6 +213,7 @@ class PHPFSPOT {
       require_once "phpfspot_tmpl.php";
       $this->tmpl = new PHPFSPOT_TMPL();
 
+      /* pre-set some template variables */
       $this->tmpl->assign('web_path', $this->cfg->web_path);
 
       /* Starting with F-Spot 0.4.2, the rating-feature was available */
@@ -410,7 +411,7 @@ class PHPFSPOT {
          $query_str="
             SELECT
                DISTINCT t1.id as id, t1.name as name
-            FROM  
+            FROM
                photo_tags pt1
             INNER JOIN photo_tags
                pt2 ON pt1.photo_id=pt2.photo_id
@@ -428,7 +429,7 @@ class PHPFSPOT {
       else
       {
          $result = $this->db->db_query("
-            SELECT id,name
+            SELECT id as id,name as name
             FROM tags
             ORDER BY sort_priority ASC
          ");
@@ -481,23 +482,40 @@ class PHPFSPOT {
       /* ~ F-Spot version 0.3.x */
       if($this->dbver < 9) {
          $query_str = "
-            SELECT p.id, p.name, p.time, p.directory_path, p.description
-            FROM photos p
+            SELECT
+               p.id as id,
+               p.name as name,
+               p.time as time,
+               p.directory_path as directory_path,
+               p.description as description
+            FROM
+               photos p
          ";
       }
       else {
          /* till F-Spot version 0.4.1 */
          if($this->dbver < 11) {
             $query_str = "
-               SELECT p.id, p.uri, p.time, p.description
-               FROM photos p
+               SELECT
+                  p.id as id,
+                  p.uri as uri,
+                  p.time as time,
+                  p.description as description
+               FROM
+                  photos p
             ";
          }
          else {
             /* rating value got introduced */
             $query_str = "
-               SELECT p.id, p.uri, p.time, p.description, p.rating
-               FROM photos p
+               SELECT
+                  p.id as id,
+                  p.uri as uri,
+                  p.time as time,
+                  p.description as description,
+                  p.rating as rating
+               FROM
+                  photos p
             ";
          }
       }
@@ -533,24 +551,24 @@ class PHPFSPOT {
          if(!isset($version_idx) || !$this->is_valid_version($idx, $version_idx))
             $version_idx = $this->get_latest_version($idx);
 
-         /* if an alternative version has been requested */
-         if($version_idx > 0) {
-
+         /* if an alternative version has been requested. But we
+            support this only for F-Spot database versions from
+            v9.
+         */
+         if($version_idx > 0 && $this->dbver >= 9) {
             /* check for alternative versions */
             if($version = $this->db->db_fetchSingleRow("
-                  SELECT
-                     version_id, name, uri
-                  FROM
-                     photo_versions
-                  WHERE
-                     photo_id LIKE '". $idx ."'
-                  AND
-                     version_id LIKE '". $version_idx ."'
-            ")) {
+               SELECT
+                  version_id, name, uri
+               FROM
+                  photo_versions
+               WHERE
+                  photo_id LIKE '". $idx ."'
+               AND
+                  version_id LIKE '". $version_idx ."'")) {
 
                $row['name'] = $version['name'];
                $row['uri'] = $version['uri'];
-
             }
          }
 
@@ -1192,7 +1210,7 @@ class PHPFSPOT {
     * @return array
     */
    public function getPhotoSelection()
-   {  
+   {
       $matched_photos = Array();
       $additional_where_cond = "";
 
@@ -1258,8 +1276,10 @@ class PHPFSPOT {
       /* return a search result */
       if(isset($_SESSION['searchfor_tag']) && $_SESSION['searchfor_tag'] != '') {
          $query_str = "
-            SELECT DISTINCT pt1.photo_id
-               FROM photo_tags pt1
+            SELECT DISTINCT
+               pt1.photo_id as photo_id
+            FROM
+               photo_tags pt1
             INNER JOIN photo_tags pt2
                ON pt1.photo_id=pt2.photo_id
             INNER JOIN tags t
@@ -1297,8 +1317,10 @@ class PHPFSPOT {
          /* photo has to match at least on of the selected tags */
          if($_SESSION['tag_condition'] == 'or') {
             $query_str = "
-               SELECT DISTINCT pt1.photo_id
-                  FROM photo_tags pt1
+               SELECT DISTINCT
+                  pt1.photo_id as photo_id
+               FROM
+                  photo_tags pt1
                INNER JOIN photo_tags pt2
                   ON pt1.photo_id=pt2.photo_id
                INNER JOIN tags t
@@ -1336,8 +1358,10 @@ class PHPFSPOT {
             */
 
             $query_str = "
-               SELECT DISTINCT pt1.photo_id
-                  FROM photo_tags pt1
+               SELECT DISTINCT
+                  pt1.photo_id as photo_id
+               FROM
+                  photo_tags pt1
             ";
 
             if(isset($this->cfg->show_tags) && !empty($this->cfg->show_tags)) {
@@ -1384,8 +1408,10 @@ class PHPFSPOT {
 
       /* return all available photos */
       $query_str = "
-         SELECT DISTINCT p.id
-         FROM photos p
+         SELECT DISTINCT
+            p.id as id
+         FROM
+            photos p
          LEFT JOIN photo_tags pt
             ON p.id=pt.photo_id
          LEFT JOIN tags t
@@ -1446,40 +1472,45 @@ class PHPFSPOT {
       }
 
       $thumbs = 0;
-      $images[$thumbs] = Array();
-      $img_height[$thumbs] = Array();
-      $img_width[$thumbs] = Array();
-      $img_id[$thumbs] = Array();
-      $img_name[$thumbs] = Array();
-      $img_fullname[$thumbs] = Array();
-      $img_title = Array();
-      $img_rating = Array();
 
       for($i = $begin_with; $i < $end_with; $i++) {
 
-         if(isset($photos[$i])) {
+         if(!isset($photos[$i]))
+            continue;
+
+         /* on first run, initalize all used variables */
+         if($thumbs == 0) {
+            $images = Array();
+            $images[$thumbs]        = Array();
+            $img_height[$thumbs]    = Array();
+            $img_width[$thumbs]     = Array();
+            $img_id[$thumbs]        = Array();
+            $img_name[$thumbs]      = Array();
+            $img_fullname[$thumbs]  = Array();
+            $img_title              = Array();
+            $img_rating             = Array();
+         }
 
-            $images[$thumbs] = $photos[$i];
-            $img_id[$thumbs] = $i;
-            $img_name[$thumbs] = htmlspecialchars($this->getPhotoName($photos[$i], 15));
-            $img_fullname[$thumbs] = htmlspecialchars($this->getPhotoName($photos[$i], 0));
-            $img_title[$thumbs] = "Click to view photo ". htmlspecialchars($this->getPhotoName($photos[$i], 0));
-            $img_rating[$thumbs] = $this->get_photo_rating($photos[$i]);
+         $images[$thumbs] = $photos[$i];
+         $img_id[$thumbs] = $i;
+         $img_name[$thumbs] = htmlspecialchars($this->getPhotoName($photos[$i], 15));
+         $img_fullname[$thumbs] = htmlspecialchars($this->getPhotoName($photos[$i], 0));
+         $img_title[$thumbs] = "Click to view photo ". htmlspecialchars($this->getPhotoName($photos[$i], 0));
+         $img_rating[$thumbs] = $this->get_photo_rating($photos[$i]);
 
-            $thumb_path = $this->get_thumb_path($this->cfg->thumb_width, $photos[$i], $this->get_latest_version($photos[$i]));
+         /* get local path of the thumbnail image to be displayed */
+         $thumb_path = $this->get_thumb_path($this->cfg->thumb_width, $photos[$i], $this->get_latest_version($photos[$i]));
 
-            if(file_exists($thumb_path)) {
-               $info = getimagesize($thumb_path); 
+         /* if the image exist and is readable, extract some details */
+         if(file_exists($thumb_path) && is_readable($thumb_path)) {
+            if($info = getimagesize($thumb_path) !== false) {
                $img_width[$thumbs] = $info[0];
                $img_height[$thumbs] = $info[1];
             }
-            $thumbs++;
-         } 
+         }
+         $thumbs++;
       }
 
-      // +1 for for smarty's selection iteration
-      $thumbs++;
-
       if(isset($_SESSION['searchfor_tag']) && $_SESSION['searchfor_tag'] != '')
          $this->tmpl->assign('searchfor_tag', $_SESSION['searchfor_tag']);
 
@@ -1604,16 +1635,20 @@ class PHPFSPOT {
       $this->tmpl->assign('preview_width', $this->cfg->photo_width);
       $this->tmpl->assign('thumb_container_width', $this->cfg->thumb_width);
       $this->tmpl->assign('thumb_container_height', $this->cfg->thumb_height+20);
-      $this->tmpl->assign('images', $images);
-      $this->tmpl->assign('img_width', $img_width);
-      $this->tmpl->assign('img_height', $img_height);
-      $this->tmpl->assign('img_id', $img_id);
-      $this->tmpl->assign('img_name', $img_name);
-      $this->tmpl->assign('img_fullname', $img_fullname);
-      $this->tmpl->assign('img_title', $img_title);
-      $this->tmpl->assign('img_rating', $img_rating);
-      $this->tmpl->assign('thumbs', $thumbs);
       $this->tmpl->assign('selected_tags', $this->getSelectedTags('img'));
+      // +1 for for smarty's selection iteration
+      $this->tmpl->assign('thumbs', $thumbs+1);
+
+      if($thumbs > 0) {
+         $this->tmpl->assign('images', $images);
+         $this->tmpl->assign('img_width', $img_width);
+         $this->tmpl->assign('img_height', $img_height);
+         $this->tmpl->assign('img_id', $img_id);
+         $this->tmpl->assign('img_name', $img_name);
+         $this->tmpl->assign('img_fullname', $img_fullname);
+         $this->tmpl->assign('img_title', $img_title);
+         $this->tmpl->assign('img_rating', $img_rating);
+      }
 
       $result = $this->tmpl->fetch("photo_index.tpl");
 
@@ -2061,7 +2096,7 @@ class PHPFSPOT {
          $full_path = $this->translate_path($this->parse_uri($details['uri'], 'fullpath'));
 
          if(!file_exists($full_path)) {
-            $this->_error("File ". $full_path ." does not exist\n");
+            $this->_error("File ". $full_path ." does not exist");
             return;
          }
 
@@ -2440,7 +2475,7 @@ class PHPFSPOT {
    private function get_photo_tags($idx)
    {
       $result = $this->db->db_query("
-         SELECT t.id, t.name
+         SELECT t.id as id, t.name as name
          FROM tags t
          INNER JOIN photo_tags pt
             ON t.id=pt.tag_id
@@ -2578,14 +2613,18 @@ class PHPFSPOT {
       switch($this->cfg->logging) {
          default:
          case 'display':
-            print "<img src=\"resources/green_info.png\" alt=\"warning\" />\n";
-            print $text ."<br />\n";
+            if(isset($this->fromcmd))
+               print $text ."\n";
+            else {
+               print "<img src=\"resources/green_info.png\" alt=\"warning\" />\n";
+               print $text ."<br />\n";
+            }
             break;
          case 'errorlog':  
             error_log($text);
             break;
          case 'logfile':
-            error_log($text, 3, $his->cfg->log_file);
+            error_log($text, 3, $this->cfg->log_file);
             break;
       }
 
@@ -3103,7 +3142,7 @@ class PHPFSPOT {
       $all = Array();
 
       $query_str = "
-         SELECT p.id
+         SELECT p.id as id
          FROM photos p
       ";
 
@@ -3145,30 +3184,36 @@ class PHPFSPOT {
    {
       $all = Array();
 
-      $query_str = "
-         SELECT p.id
-         FROM photos p
-         INNER JOIN photo_tags pt
-            ON p.id=pt.photo_id
-      ";
-
       if(isset($this->cfg->show_tags) && !empty($this->cfg->show_tags)) {
          $query_str.= "
-            INNER JOIN tags t
-               ON pt.tag_id=t.id
-         ";
+            SELECT
+               DISTINCT pt1.photo_id as id
+            FROM
+               photo_tags pt1
+            INNER JOIN photo_tags
+               pt2 ON pt1.photo_id=pt2.photo_id
+            INNER JOIN tags t1
+               ON t1.id=pt1.tag_id
+            INNER JOIN tags t2
+               ON t2.id=pt2.tag_id
+            WHERE
+               pt1.tag_id LIKE '". $tagidx ."'
+            AND
+               t2.name IN  ('".implode("','",$this->cfg->show_tags)."')
+            ORDER BY
+               t1.sort_priority ASC";
+      }
+      else {
+         $query_str = "
+            SELECT
+               p.id as id
+            FROM
+               photos p
+            INNER JOIN photo_tags pt
+               ON p.id=pt.photo_id
+            WHERE
+               pt.tag_id LIKE '". $tagidx ."'";
       }
-      $query_str.= "
-         WHERE
-            pt.tag_id LIKE '". $tagidx ."'
-      ";
-
-      /*if(isset($this->cfg->show_tags) && !empty($this->cfg->show_tags)) {
-         $query_str.= "
-           AND
-               t.name IN ('".implode("','",$this->cfg->show_tags)."')
-         ";
-      }*/
 
       $result = $this->db->db_query($query_str);
 
@@ -3494,14 +3539,14 @@ class PHPFSPOT {
       $to_delete = Array();
 
       $result = $this->cfg_db->db_query("
-         SELECT img_idx
+         SELECT img_idx as img_idx
          FROM images
          ORDER BY img_idx ASC
       ");
 
       while($row = $this->cfg_db->db_fetch_object($result)) {
          if(!$this->db->db_fetchSingleRow("
-            SELECT id
+            SELECT id as id
             FROM photos
             WHERE id='". $row['img_idx'] ."'")) {
 
@@ -3580,7 +3625,7 @@ class PHPFSPOT {
    public function get_tag_name($idx)
    {
        if($result = $this->db->db_fetchSingleRow("
-         SELECT name
+         SELECT name as name
          FROM tags
          WHERE
             id LIKE '". $idx ."'")) {
@@ -3687,7 +3732,7 @@ class PHPFSPOT {
    public function get_db_version()
    {
       if($row = $this->cfg_db->db_fetchSingleRow("
-         SELECT meta_value
+         SELECT meta_value as meta_value
          FROM
             meta
          WHERE