some cleanup
[e-DoKo.git] / index.php
index a53a23c3b163d789c08df73474303527911f82ae..f2228988735f7ae6b926a33eb4b972afc453d8b7 100644 (file)
--- a/index.php
+++ b/index.php
@@ -6,10 +6,36 @@
      <title>e-Doko</title>
      <meta content="text/html; charset=ISO-8859-1" http-equiv="content-type" />
      <link rel="stylesheet" type="text/css" href="standard.css" />     
+     <script type="text/javascript">
+       function hl(num) {
+         if(document.getElementById){
+          var i;
+          for(i=1;i<13;i++){
+            if(document.getElementById("trick"+i))
+              document.getElementById("trick"+i).style.display = 'none';
+          }
+          document.getElementById("trick"+num).style.display = 'block';
+        }
+       }
+       function high_last(){
+        if(document.getElementById){
+          var i;
+          for(i=12;i>0;i--) {
+            if(document.getElementById("trick"+i))
+              {
+                hl(i);
+                break;
+              }
+          }
+        }
+       }
+     </script>
   </head>
-<body>
+<body onload="high_last();">
+<div class="header">
 <h1> Welcome to E-Doko </h1>
 <?php
+
 /*
  * config 
  */
@@ -18,11 +44,17 @@ $host  = "http://doko.nubati.net/index.php";
 $wiki  = "http://wiki.nubati.net/index.php?title=EmailDoko";
 $debug = 1;
 
+$last=-2;
+
 /*
  * end config
  */    
-                                       
 
+echo "</div>\n";
+
+/* end header */
+
+                                       
 /* helper function */
 function mymail($To,$Subject,$message)
 {  
@@ -38,6 +70,73 @@ function mymail($To,$Subject,$message)
   return;
 }
 
+function is_trump($c) { return (($c<27) ? 1:0);}
+function is_club($c)  { return (in_array($c,array('27','28','29','30','31','32','33','34')));}
+function is_spade($c) { return (in_array($c,array('35','36','37','38','39','40','41','42')));}
+function is_heart($c) { return (in_array($c,array('43','44','45','46','47','48')));}
+
+function compare_cards($a,$b)
+{
+  /* if a is higher than b return 1, else 0, a being the card first played */
+  
+  /* first map all cards to the odd number */
+  if( $a/2 - (int)($a/2) != 0.5)
+    $a--;
+  if( $b/2 - (int)($b/2) != 0.5)
+    $b--;
+  
+  if(is_trump($a) && $a<=$b)
+    return 1;
+  else if(is_trump($a) && $a>$b)
+    return 0;
+  else 
+    { /*$a is not a trump */
+      if(is_trump($b))
+       return 0;
+      else
+       {
+         /* both clubs? */
+         if( is_club($a) && is_club($b))
+           if($a<=$b)
+             return 1;
+           else
+             return 0;
+         /* both spade? */
+         if( is_spade($a) && is_spade($b))
+           if($a<=$b)
+             return 1;
+           else
+             return 0;
+         /* both heart? */
+         if( is_heart($a) && is_heart($b))
+           if($a<=$b)
+             return 1;
+           else
+             return 0;
+      return 1;
+       }         
+    }
+      
+} 
+
+function get_winner($p)
+{
+  /* get all 4 cards played in a trick */
+  $c1 = $p[0];
+  $c2 = $p[1];
+  $c3 = $p[2];
+  $c4 = $p[3];
+
+  /* find out who won */
+  if( compare_cards($c1,$c2) && compare_cards($c1,$c3) && compare_cards($c1,$c4) )
+    return 0;
+  if( compare_cards($c2,$c3) && compare_cards($c2,$c4) )
+    return 1;
+  if( compare_cards($c3,$c4) )
+    return 2;
+  return 3;
+}
+
 function parse_status()
 {
   global $game,$history,$player,$hash,$lines;
@@ -91,12 +190,8 @@ function parse_status()
     }  
   /* save the game history */
   for($i=4;$i<sizeof($lines);$i++)
-    {
-      if(!ereg("^[[:space:]]*$",trim($lines[$i])))
-       {
-         $history[] = $lines[$i];
-       }
-    }
+    if(!ereg("^[[:space:]]*$",trim($lines[$i])))
+      $history[] = $lines[$i];
   
   if(sizeof($history)==0 || (sizeof($history)==1 && strlen($history[0])==3 ))
     $history[0] = $game["startplayer"].":";
@@ -106,9 +201,8 @@ function parse_status()
 
 function count_nines($cards)
 {
-  $card = explode(";",$cards);
-  
-  $nines =0;
+  $card  = explode(";",$cards);
+  $nines = 0;
 
   foreach($card as $c)
     {
@@ -123,37 +217,36 @@ function count_nines($cards)
 
 function check_wedding($cards)
 {
-  $card = explode(";",$cards);
-  
-  $count =0;
+  $card  = explode(";",$cards);
 
   if( in_array("3",$card) && in_array("2",$card) )
-    $count=1;
+    return 1;
 
-  return $count;
+  return 0;
 }
 
 function count_trump($cards)
 {
-  $card = explode(";",$cards);
-  
-  $trump =0;
+  $card  = explode(";",$cards);
+  $trump = 0;
 
   /* count each trump */
   foreach($card as $c)
-    {
-      if( (int)($c) <27) $trump++;
-    }
+    if( (int)($c) <27) 
+      $trump++;
 
-  /* subtract one, in case player has both foxes */
-  if( in_array("19",$card) && in_array("20",$card) )
+  /* subtract foxes */
+  if( in_array("19",$card))
+    $trump--;
+  if( in_array("20",$card) )
     $trump--;
+  /* add one, in case the player has both foxes (schweinchen) */
+  if( in_array("19",$card) && in_array("20",$card) )
+    $trump++;
 
   return $trump;
 }
 
-
-
 function card_to_name($card)
 {
   switch($card)
@@ -231,101 +324,94 @@ function card_to_name($card)
       case 48:
       return "nine of hearts";
       default:
-      return "something went wrong, please contact the admin";
+      return "something went wrong, please contact the admin. Error: code1.";
     }
 }
 
 function card_value($card)
 {
-  switch($card-1)
+  switch($card)
     {
-      case 0:
-      case 1:
-        return 10;
-      case 2:
-      case 3:
-      case 4:
-      case 5:
-      case 6:
-      case 7:
-      case 8:
-      case 9:
-        return 3;
-      case 10:
-      case 11:
-      case 12:
-      case 13:
-      case 14:
-      case 15:
-      case 16:
-      case 17:
-        return 2;
-      case 18:
-      case 19:
-        return 11;
-      case 20:
-      case 21:
-        return 10;
-      case 22:
-      case 23:
-        return 4;
-      case 24:
-      case 25:
-      return 0;
-      case 26:
-      case 27:
-      return 11;
-      case 28:
-      case 29:
+    case 1:      /* heart */
+    case 2:
       return 10;
-      case 30:
-      case 31:
-      return 4;
-      case 32:
-      case 33:
-      return 0;
-      case 34:
-      case 35:
+    case 3:     /* clubes */    
+    case 4:                     
+    case 5:     /* spades */    
+    case 6:                     
+    case 7:     /* hearts */    
+    case 8:                     
+    case 9:     /* diamonds */  
+    case 10:                     
+      return 3;
+    case 11:    /* clubes */    
+    case 12:                    
+    case 13:   /* spades */     
+    case 14:                    
+    case 15:   /* hearts */     
+    case 16:                    
+    case 17:   /* diamonds */   
+    case 18:
+      return 2;                         
+    case 19:    /* diamonds */ 
+    case 20:                  
+    case 27:    /* clubs */    
+    case 28:                  
+    case 35:    /* spades */   
+    case 36:                  
+    case 43:    /* hearts */   
+    case 44:                   
       return 11;
-      case 36:
-      case 37:
+    case 21:    /* diamonds */    
+    case 22:
+    case 29:    /* clubs */
+    case 30:
+    case 37:    /* spades */
+    case 38:
       return 10;
-      case 38:
-      case 39:
+    case 23:    /* diamonds */ 
+    case 24:                  
+    case 31:   /* clubs */    
+    case 32:                  
+    case 39:   /* spades */   
+    case 40:                  
+    case 45:   /* hearts */   
+    case 46:                  
       return 4;
-      case 40:
-      case 41:
+    case 25:    /* diamonds */   
+    case 26:                  
+    case 33:   /* clubs */    
+    case 34:                  
+    case 41:   /* spades */   
+    case 42:                  
+    case 47:   /* hearts */   
+    case 48:                  
       return 0;
-      case 42:
-      case 43:
-      return 11;
-      case 44:
-      case 45:
-      return 4;
-      case 46:
-      case 47:
-      return 0;
-      default:
-      echo "something went wrong, please contact the admin <br>";
+    default:
+      echo "something went wrong, please contact the admin. ErrorCode: 2<br>";
       return 0;
     }
 }
 
 function display_card($card)
 {
+  /* cards are only availabl for the odd values, e.g. 1.png, 3.png, ... 
+   * convert even cards to the matching odd value */
+
   if( $card/2 - (int)($card/2) == 0.5)
     echo "<img src=\"cards/".$card.".png\"  alt=\"".card_to_name($card)."\" />\n";
   else
     echo "<img src=\"cards/".($card-1).".png\"  alt=\"".card_to_name($card-1)."\" />\n";
+
   return;
 }
 
 function display_link_card($card,$me)
 {
   if( $card/2 - (int)($card/2) == 0.5)
-    echo "<a href=\"index.php?me=$me&amp;card=$card\"><img src=\"cards/".$card.".png\"  alt=\"".card_to_name($card)."\" /></a>\n";
+    echo "<input type=\"radio\" name=\"card\" value=\"".$card."\" /><img src=\"cards/".$card.".png\" alt=\"\" />\n";
   else
-    echo "<a href=\"index.php?me=$me&amp;card=$card\"><img src=\"cards/".($card-1).".png\"  alt=\"".card_to_name($card-1)."\" /></a>\n";
+    echo "<input type=\"radio\" name=\"card\" value=\"".$card."\" /><img src=\"cards/".($card-1).".png\" alt=\"\" />\n";
   return;
 }
 
@@ -387,14 +473,13 @@ function save_status()
       fclose($output);
     }
   else
-    echo "can't open file for writing, please inform the admin.";
+    echo "can't open file for writing, please inform the admin.errorcode3";
   
   return;
 }
 
-echo "<p>If you find bugs, please list them in the <a href=\"".$wiki."\">wiki</a></p>\n";
-       
-echo "<p> Cards that have a <span class=\"comment\"> green </span> background have a comment, which you can access by hovering over the card with your mouse ;)</p>\n";
+/*****************  M A I N **************************/
+
 
 $history=array();
 
@@ -402,8 +487,8 @@ $history=array();
 
 if(file_exists("status.txt"))
   $lines = file("status.txt");
- else
-   die("no file");
+else
+  die("no file");
 
 /* check if we want to start a new game */
 if( isset($_REQUEST["PlayerA"]) && 
@@ -517,9 +602,9 @@ if(sizeof($lines)<2)
  </form>
 <?php
    }
- else
-   { /* load game status */
-     parse_status();
+else
+  { /* load game status */
+    parse_status();
 /*     **
  *    *  *
  *    ****
@@ -527,18 +612,16 @@ if(sizeof($lines)<2)
  *
  * check if a player wants to accept a game 
  */
-     
-     if(isset($_REQUEST["a"]))
-       {
-        $a=$_REQUEST["a"];
-        
-        if( ereg("[is]",$player[$a]["option"]) &&  $game["init"]<4)
-          {
-            echo "just wait for the game to start";
-          }
-        else  if( !ereg("[is]",$player[$a]["option"]) )
-          {
-
+    if(isset($_REQUEST["a"]))
+      {
+       $a = $_REQUEST["a"];
+       
+       if( ereg("[is]",$player[$a]["option"]) &&  $game["init"]<4)
+         {
+           echo "just wait for the game to start";
+         }
+       else if( !ereg("[is]",$player[$a]["option"]) )
+         {
  ?>
  <form action="index.php" method="post">
    Do you want to play a game of DoKo?
@@ -555,7 +638,6 @@ if(sizeof($lines)<2)
             echo " </form>\n";
           }
        }
-
 /*   ***
  *   *  *
  *   ***
@@ -565,56 +647,59 @@ if(sizeof($lines)<2)
  */
      if(isset($_REQUEST["b"]))
        {
-        $b=$_REQUEST["b"];
+        $b = $_REQUEST["b"];
         
         if( ereg("s",$player[$b]["option"])  && $game["init"]<4)
-          {
+          { /* the player already filled out everything */
             echo "just wait for the game to start";
           }
         else if( (!isset($_REQUEST["in"])|| !isset($_REQUEST["update"])) && !ereg("i",$player[$b]["option"]))
-          {
+          { /* the player didn't fill out the form at "a" correctly */
             echo "go back to ";
             echo "<a href=\"index.php?a=$b\"> here and fill out the form </a> <br />\n";
           }
         else
-          { /* show the hand */
+          { /* show the hand and check if the player is sick*/
             if($_REQUEST["in"]=="no")
-              {
+              { /* player doesn't want to play, cancel the game */
                 for($i=0;$i<4;$i++)
                   {
                     $message = "Hello ".$player[$hash[$i]]["name"].",\n\n".
                       "the game has been canceled due to the request of one of the players.\n";
                     mymail($player[$hash[$i]]["email"],"[DoKo-Debug] the game has been canceled",$message); 
                   }
-                  $output = fopen("status.txt","w");
-                  if($output)
-                    fclose($output);
-                  else
-                    echo "problem opening file";
+                /* canceling the game is as easy as removing the contents of the status file*/
+                $output = fopen("status.txt","w");
+                if($output)
+                  fclose($output);
+                else
+                  echo "problem opening file";
               }
             else
               {
-                if($_REQUEST["update"]=="card") $player[$b]["option"].="c";
-                if($_REQUEST["update"]=="turn") $player[$b]["option"].="t";
+                /* player wants to play, save information from "a"*/
+                if($_REQUEST["update"]=="card") 
+                  $player[$b]["option"] .= "c";
+                else
+                  $player[$b]["option"] .= "t";
                 
-                $player[$b]["option"].="i";
+                $player[$b]["option"] .= "i"; /* player finished stage "a" */
                 
                 save_status();
                 
                 $allcards = $player[$b]["cards"];
-                $mycards = explode(";",$allcards);
+                $mycards  = explode(";",$allcards);
                 
                 sort($mycards);
-                echo "your cards are <br />\n";
+                echo "<p class=\"mycards\">your cards are: <br />\n";
                 foreach($mycards as $card) 
-                  {
-                    display_card($card);
-                  }
-                echo "<br />\n";   
+                  display_card($card);
+                echo "</p>\n";   
  ?>
- <p>aehm... at the moment poverty is not implented. so I guess you need to play a normal game, even if you have less than 3 turmp :(...sorry</p>                 
+ <p> aehm... at the moment poverty is not implented. so I guess you need to play a normal game, even if you have less than 3 trump :(...sorry </p>               
+
  <form action="index.php" method="post">
-   
+
    do you want to play solo? 
    <select name="solo" size="1">
      <option>No</option>
@@ -670,21 +755,26 @@ if(sizeof($lines)<2)
               }
           }
        }
+
      if(isset($_REQUEST["c"]))
        {
-        $c=$_REQUEST["c"];
+        $c = $_REQUEST["c"];
         
-        if(!isset($_REQUEST["solo"])|| !isset($_REQUEST["wedding"])|| !isset($_REQUEST["poverty"]) || !isset($_REQUEST["nines"]) )
-          {
+
+        if( ereg("s",$player[$c]["option"]) && $game["init"]<4 )
+          { /* the player already filled out everything */
+            echo "<p>just wait for the game to start</p>\n";
+          }
+        else if(!isset($_REQUEST["solo"])    || 
+                !isset($_REQUEST["wedding"]) ||
+                !isset($_REQUEST["poverty"]) ||
+                !isset($_REQUEST["nines"]) )
+          {/* player still needs to fill out the form */
             echo "go back to ";
             echo "<a href=\"index.php?b=$c\"> here and fill out the form </a> <br />\n";
           }
-        else if(  ereg("s",$player[$c]["option"]) && $game["init"]<4 )
-          {
-            echo "just wait for the game to start";
-          }
         else if($game["init"]<4)
-          { 
+          { /* save information */
             if( $_REQUEST["solo"]!="No")
               {
                 switch($_REQUEST["solo"])
@@ -728,46 +818,56 @@ if(sizeof($lines)<2)
                 $player[$c]["option"].="N";
               }
             
-            $message = "You're in. Once everyone has filled out the form, ".
-              "the game will start and you'll get an eamil on your turn.\n";
-            mymail($player[$c]["email"],"[DoKo-debug] the game will start soon",$message); 
-
+            /* player finished setup */
             $player[$c]["option"].="s";
+
             save_status();
+            /* reread status file, to get the correct startplayer, etc */
             if(file_exists("status.txt"))
               $lines = file("status.txt");
             else
               die("no file");
             parse_status();
 
-            if($game["init"]==4)
+            if($game["init"]==4 && $player[$c]["number"]==$game["startplayer"])
+              {
+                echo "<p> The game can start now, it's your turn, please use this <a href=\"".
+                  $host."?me=".$hash[$c]."\">link</a> to play a card.</p>\n";
+              }
+            else if($game["init"]==4)
               {
                 $message = "The game can start now, it's your turn, please use this link to play a card:\n".
                   $host."?me=".$hash[$game["startplayer"]]."\n";
                 mymail($player[$hash[$game["startplayer"]]]["email"],"[DoKo-debug] let's go",$message);
+                echo "<p> The game has started. An email has been sent out to the first player.</p>\n";
+              }
+            else
+              {
+                echo "<p>You're in. Once everyone has filled out the form, ".
+                  "the game will start and you'll get an eamil on your turn.</p>\n";
               }
-            
           }
        }
+     /* END SETUP */
+
+     /* the game */
      if($game["init"]==4)
        {
-        /* check for sickness*/
-        /***** someone has 5 nines and no one is playing solo=> cancel game */
+        /* check for sickness, only would need to do this on the first trick really...*/
+        /***** someone has 5 nines and no one is playing solo => cancel game */
         if($game["nines"]>=0 && $game["solo-who"]<0)
           {
             $message = $player[$hash[$game["poverty"]]]["nines"]." has more than 4 nines. Game aborted!\n";
             for($i=0;$i<4;$i++)
-              {
-                mymail($player[$hash[$i]]["email"],"[DoKo-debug] the game has been canceled",$message); 
-              };
-
+              mymail($player[$hash[$i]]["email"],"[DoKo-debug] the game has been canceled",$message); 
+            
             $output = fopen("status.txt","w");
             if($output)
               fclose($output);
             else
               echo "problem opening file";
-          }
-
+          };
+        
         /* who is requesting this*/
         if(!isset($_REQUEST["me"]))
           {    
@@ -784,21 +884,21 @@ if(sizeof($lines)<2)
                }
             else
               {
-                $recovery=$_REQUEST["recovery"];
-                $ok=-1;
+                $recovery = $_REQUEST["recovery"];
+                $ok = -1;
                 for($i=0;$i<4;$i++)
                   if(trim($recovery)==trim($player[$hash[$i]]["email"]))
-                    $ok=$i;
+                    $ok = $i;
                 if($ok>=0)
                   {
                     $message = "Please try this link: ".$host."?me=".$hash[$ok]."\n".
-                      "\n if this doesn't work, contact the admin.\n";
+                      "\n if this doesn't work, contact the admin.error4\n";
                     mymail($recovery,"[DoKo-Debug] recovery ",$message);
-                    echo "email has been sent.";
+                    echo "<p> An email with the game information has been sent.</p>\n";
                   }
                 else
                   {
-                    echo "can't find this email address, sorry.";
+                    echo "<p> can't find this email address, sorry.</p>\n";
                   }; 
               } /* end recovery */
           }
@@ -806,54 +906,81 @@ if(sizeof($lines)<2)
           { /* $me is set */ 
             $me = $_REQUEST["me"];
             
-            /* output if we are playing a solo or a wedding */
-            if($game["solo-who"]>=0)
-              echo $player[$hash[$game["solo-who"]]]["name"]." is playing a ".$game["solo-what"]." solo!<br />\n";
-            else if($game["wedding"]>=0)
-              echo $player[$hash[$game["wedding"]]]["name"]." is playing a wedding!<br />\n";
-            
             /* show history */
+            /* old tricks as list */
+            echo "<ul class=\"oldtrick\">\n";
+            echo "  <li> History: </li>\n";
+            $j=0;
             foreach($history as $play) 
               {
+                $j++;
                 $trick = explode(":",$play);
                 
-                $last=-2;
                 /* found old trick, display it */
                 if(sizeof($trick)==5)
-                  echo "<div class=\"oldtrick background".$play[0]."\"><div class=\"table\">\n";
+                  echo "  <li onclick=\"hl('$j');\"><a href=\"#\">Trick $j</a>\n    <div class=\"table\" id=\"trick".$j."\">\n      <img class=\"table\" src=\"pics/table".$play[0].".png\" alt=\"table\" />\n";
                 else
-                  echo "<div class=\"trick back".$play[0]."\"><div class=\"table\">\n";
+                  {
+                    /* display current trick */
+                    echo "<li onclick=\"hl('$j');\"><a href=\"#\">Current Trick</a>\n  <div class=\"table\" id=\"trick".$j."\">\n      <img class=\"table\" src=\"pics/table".$play[0].".png\" alt=\"table\" />";
+                  }
                 for($i=0;$i<sizeof($trick)-1;$i++)
                   {
                     $card = $trick[$i];
+
+                    $last=-2;
+                    /* has a card been played? */
                     if(ereg("->",$card))
                       {
                         $tmp = explode("->",$card);
 
+                        echo "      <div class=\"card".$tmp[0]."\">\n";
+
                         if(strlen($tmp[2])>0)
-                          echo "<div class=\"card".$tmp[0]." comment\">";
+                          echo "        <span class=\"comment\">";
                         else
-                          echo "<div class=\"card".$tmp[0]."\">";
-                        echo $player[$hash[$tmp[0]]]["name"]."  <br />";
-                        display_card($tmp[1]);
+                          echo "        <span>";
+                        echo $player[$hash[$tmp[0]]]["name"];
                         /* check for comment */
                         if(strlen($tmp[2])>0)
-                          echo "<div class=\"comment\">".$tmp[2]."</div>\n";
+                          echo "<span>".$tmp[2]."</span>";
+                        echo "</span>\n        ";
+       
+                        display_card($tmp[1]);
+
                         $last = $tmp[0];
-                        echo "</div>\n";
+                        echo "      </div>\n";
                       }
                   }
-                echo "</div></div>\n";
+                
+                echo "    </div>\n  </li>\n";
               }
-            
+            echo "</ul>\n";
+
+            echo "<div class=\"line\"></div>";
+
+            /* output if we are playing a solo or a wedding */
+            echo "<div class=\"info\">";
+            if($game["solo-who"]>=0)
+              echo $player[$hash[$game["solo-who"]]]["name"]." is playing a ".$game["solo-what"]." solo!<br />\n";
+            else if($game["wedding"]>=0)
+              echo $player[$hash[$game["wedding"]]]["name"]." is playing a wedding!<br />\n";
+            echo "</div>";
+            echo "<div class=\"bug\"> Poverty not working yet! <br />".
+              " Schweinchen not working yet <br />".
+              "Bug: at the end of the game the winner of the last trick can add more points to his score by reloading the page <br />".
+              "If you find more bugs, please list them in the <a href=\"".$wiki.
+              "\">wiki</a>.Hit shift reload every now and then too.</div>\n";
+
+
             /* figure out who needs to play next */
             $next = $last + 1;
             if ($next>=4) 
               $next -= 4 ;
+
+            /* if no one has played yet or we are at the start of a new trick */
             if($last<0)
-              {
-                $next = $history[sizeof($history)-1][0];
-              }
+              $next = $history[sizeof($history)-1][0];
             
             /* are we trying to play a card? */
             if(isset($_REQUEST["card"]))
@@ -862,6 +989,8 @@ if(sizeof($lines)<2)
                   {
                     $card    = $_REQUEST["card"];
                     $mycards = explode(";",$player[$me]["cards"]);
+                    $comment = $_REQUEST["comment"];
+                    $comment = str_replace(":","",$comment);           /*can't have ":" in comments */
                     
                     /* do we have that card */
                     if(in_array($card,$mycards))
@@ -883,12 +1012,12 @@ if(sizeof($lines)<2)
                         /* add card to history, special case if this is the first card */
                         if($last<0)
                           {
-                            $history[sizeof($history)-1]="".$player[$me]["number"]."->".$card.":\n";
+                            $history[sizeof($history)-1]="".$player[$me]["number"]."->".$card."->$comment:\n";
                           }
                         else
                           {
                             $tmp = explode(":",$history[sizeof($history)-1]);
-                            $tmp[sizeof($tmp)-1] = "".$player[$me]["number"]."->".$card.":";
+                            $tmp[sizeof($tmp)-1] = "".$player[$me]["number"]."->".$card."->$comment:";
                             $history[sizeof($history)-1]=join(":",$tmp);
                           }
                         save_status();
@@ -898,14 +1027,6 @@ if(sizeof($lines)<2)
                         display_card($card);
                         echo "</div>\n";
 
-                        ?>
-<br clear="both" />
-<form action="index.php" method="post">
-   A short comment:<input name="comment" type="text" size="30" maxlength="50" /> 
-   <input type="hidden" name="me" value="<?php echo $me; ?>" />
-   <input type="submit" value="submit comment" />
-</form>
-<?php
                         /* send out email to players who want/need to get informed */
                          /* check if we are in a trick, if trick is done, this needs to be handelt in the
                          * who-won-the-trick section further down */
@@ -940,30 +1061,27 @@ if(sizeof($lines)<2)
                       }
                     else
                       echo "seems like you don't have that card<br />\n";
-                    
                   }
-                
               } /* end if card is set */
-            else if(isset($_REQUEST["comment"]))
-              {
-                $comment = $_REQUEST["comment"];
-                $tmp = explode(":",$history[sizeof($history)-1]);
-                $tmp2 = explode("->",$tmp[sizeof($tmp)-2]);
-                
-                $comment = str_replace(":","",$comment);
+           if(substr_count($history[sizeof($history)-1],":")==4)
+              { /* count points, email winner */
+                $p = array();
+                $c = array();
 
-                if(sizeof($tmp2)<=2)
-                  $tmp[sizeof($tmp)-2] .= "->".$comment;
-                $history[sizeof($history)-1]=join(":",$tmp);
+                $tmp  = explode(":",$history[sizeof($history)-1]); /*last played trick */
 
-                save_status();
-              }
-            else if(isset($_REQUEST["win"]) && strlen($history[sizeof($history)-1])>3)
-              {
-                $win       = $_REQUEST["win"];
+                /* get player and cards of last trick */
+                for($i=0;$i<4;$i++)
+                  {
+                    $tmp2 = explode("->",$tmp[$i]);
+                    $p[] = $tmp2[0];
+                    $c[] = $tmp2[1];
+                  };
                 
+                $win = $p[get_winner($c)];
+                                
                 if(strlen($player[$hash[0]]["cards"]))
-                   $history[] = $win.":\n";
+                  $history[] = "\n".$win.":\n"; /* not sure why I need the first \n here */
 
                 /* email the player who needs to move next*/
                 for($i=0;$i<4;$i++)
@@ -992,7 +1110,6 @@ if(sizeof($lines)<2)
                       }
                   }
                 
-                
                 /* count points of the last trick */
                 $points = 0;
 
@@ -1010,74 +1127,53 @@ if(sizeof($lines)<2)
               }; /* end if win is set */
             echo "<br />\n";
 
-            $tmp = explode(":",$history[sizeof($history)-1]);
-
-            /* check last history entry: end of a trick? ask who won it, unless it was the last trick */
-            if(sizeof($tmp)==5 && strlen($player[$hash[0]]["cards"]))
-              {
-                ?>
-<form action="index.php" method="post">
-who won?
-<?php 
-   for($i=0;$i<4;$i++)
-     echo $player[$hash[$i]]["name"]." <input type=\"radio\" name=\"win\" value=\"$i\" />";
-   echo "<input type=\"hidden\" name=\"me\" value=\"$me\" />";
-?>
-<input type="submit" value="submit" />
-
-</form>
-<?php
-               }
-            else if(sizeof($tmp)<5 && 1<sizeof($tmp) && !isset($_REQUEST["card"]))
-              {                 
-                if(sizeof($tmp)==2 && strlen($tmp[0])==1)
+            /* check if game is done */
+            $end = 1;
+            for($i=0;$i<4;$i++)
+              if(strlen(trim($player[$hash[$i]]["cards"]))!=0)
+                $end = 0;
+            
+            if($end)
+              { 
+                echo "<br /> game over, count points <br />\n";
+                for($i=0;$i<4;$i++)
                   {
-                    $next=$tmp[0];
-                    
-                    if($debug)
-                      echo "DEBUG: the next move is for <a href=\"index.php?me=".$hash[$next]."\">the next player</a><br />\n";
-                    
-                    if(strlen(trim($player[$me]["cards"]))==0)
-                      {
-                        echo "<br /> game over, count points <br />\n";
-                        for($i=0;$i<4;$i++)
-                          {
-                            echo $player[$hash[$i]]["name"]." got ".$player[$hash[$i]]["points"]."<br />\n";
-                          }
-                      }
+                    echo $player[$hash[$i]]["name"]." got ".$player[$hash[$i]]["points"]."<br />\n";
                   }
-                echo "<br />\n";
-              } /* end check for winner */
-            
-            echo "<br clear=\"both\" />";
+              }
+            /* check end of game */
+  
             /* do we still have cards? display them */
             if(strlen(trim($player[$me]["cards"]))>0 )
               {
                 $allcards = trim($player[$me]["cards"]);
-                $mycards = explode(";",$allcards);
+                $mycards  = explode(";",$allcards);
                 
                 sort($mycards);
                 
-                echo "<p class=\"mycards\">\n";
+                echo "<div class=\"mycards\">\n";
                 /* is it our turn? */
-                if($hash[$next]==$me && !isset($_REQUEST["card"]) && !isset($_REQUEST["win"])
+                if($hash[$next]==$me && !isset($_REQUEST["card"])) 
                   {
-                    echo "ITS YOUR TURN   <br />\n";
-                    echo "your cards are: <br />\n";
+                    echo "Hello ".$player[$me]["name"].", it's your turn!  <br />\n";
+                    echo "Your cards are: <br />\n";
+                    echo "<form action=\"index.php\" method=\"post\">\n";
                     foreach($mycards as $card) 
-                      {
-                        display_link_card($card,$me);
-                      }
+                      display_link_card($card,$me);
+?>
+   <br />A short comment:<input name="comment" type="text" size="30" maxlength="50" /> 
+   <input type="hidden" name="me" value="<?php echo $me; ?>" />
+   <input type="submit" value="move" />
+</form>
+<?php
                   }
                 else 
                   { /* not our turn, just show the hand */
-                    echo "your cards are: <br />\n";
+                    echo "Your cards are: <br />\n";
                     foreach($mycards as $card) 
-                      {
-                        display_card($card);
-                      }
+                      display_card($card);
                   }
-                echo "</p>\n";   
+                echo "</div>\n";   
               }
           }
        }
@@ -1087,3 +1183,12 @@ who won?
 ?>
 </body>
 </html>
+
+<?php
+/*
+ *Local Variables: 
+ *mode: php
+ *mode: hs-minor
+ *End:
+ */
+?>