From 1e258af4136567ab30ce9b54aee751077f80590e Mon Sep 17 00:00:00 2001
From: Arun Persaud <arun@nubati.net>
Date: Tue, 8 May 2012 21:25:49 -0700
Subject: BUGFIX: removed side effect from getting the user's preferences: the
 language used could be overwritten by another user's choise

the DB_get_Prefs($myid) functions used to set the _SESSION variable for the language, but was also called with ids that belonged to other players overwriting the language settings with that from another user
---
 index.php | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

(limited to 'index.php')

diff --git a/index.php b/index.php
index 4b716f8..51aa24d 100644
--- a/index.php
+++ b/index.php
@@ -58,13 +58,12 @@ if($DBopen<0)
 if(myisset('language') || isset($_SESSION['language']))
   {
     $language = 'en';
-    if(isset($_SESSION['language']))
-       $language = $_SESSION['language'];
+
     if(myisset('language'))
-      {
-	$language = $_REQUEST['language'];
-	$_SESSION['language'] = $language; /* overrule preferences */
-      }
+      $language = $_REQUEST['language'];
+    else if(isset($_SESSION['language']))
+      $language = $_SESSION['language'];
+
     switch($language)
       {
       case 'de':
-- 
cgit v1.2.3-18-g5258